config reload needs to restart services #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Nov 7, 2017
config/main.py
Outdated
| p.wait() | ||
| hostname = p.communicate()[0].strip() | ||
| _change_hostname(hostname) | ||
| run_command("service interfaces-config restart", display_cmd=True) |
There was a problem hiding this comment.
Lines 139-148 duplicates lines 195-204. Please create a separate function (e.g., restart_services()) to contain these lines so they only need to be modified in one place.
|
@taoyl-ms to review. |
|
Comment addressed. |
jleveque
approved these changes
Nov 9, 2017
|
@taoyl-ms please check |
taoyl-ms
approved these changes
Nov 14, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
- Encapsulate all PsuChassisInfo test cases in a TestPsuChassisInfo class - Move TestPsuChassisInfo to its own file, test_PsuChassisInfo.py - Increase coverage of PsuChassisInfo class - Increase coverage of TestDaemonPsud class - In all test scripts, use `import psud` rather than `from psud import *` and reference everything using the `psud.` namespace. Also do the same with `mock` - Remove unnecessary try/except around import statements in psud - Add unit tests for signal_handler - Fix `TypeError: cannot concatenate 'str' and 'int' objects` in signal_handler Overall psud unit test coverage increases from 51% to 78%.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Update transceiver info DB key names (sonic-net#146) [Multiasic]: Provide namespace support for ipNetToMediaPhysAddress (sonic-net#129) [LLDP]: Modify OID index of LLDPRemTableUpdater MIB (sonic-net#155) [Namespace]: Simplify sync_d functions to use higher order (sonic-net#154) [Namespace]: Fix interface counters in RFC 1213 (sonic-net#145) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
LGTM tool is now active for the sonic-platform-common repo. - Add LGTM badges to README.md - Fix 26 LGTM alerts: - 17 for Unused import - 9 for Except block handles 'BaseException'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.